Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #960 - 2 lines (instead of 1) for "importance", and radio button on top #1760

Merged
merged 2 commits into from
May 6, 2022
Merged

feat: #960 - 2 lines (instead of 1) for "importance", and radio button on top #1760

merged 2 commits into from
May 6, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • attribute_button.dart: 2 lines (instead of 1) for "importance", and radio button on top
  • user_preferences_page-blue-dark.png: golden refresh
  • user_preferences_page-blue-light.png: golden refresh
  • user_preferences_page-brown-dark.png: golden refresh
  • user_preferences_page-brown-light.png: golden refresh
  • user_preferences_page-green-dark.png: golden refresh
  • user_preferences_page-green-light.png: golden refresh

What

  • When I tested the preference page in Italian, that didn't look good because the importance text could not fit in 1 line ("Non è") (and a second line "importante" was missing)
  • I've switched to 2 lines instead of 1, but then the combination of the text and the radio button didn't look good
  • I've moved the radio button to the top of the text, and that looks more coherent

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-05-05 at 20 33 39

Part of

@monsieurtanuki
feat: openfoodfacts#960 - 2 lines (instead of 1) for "importance", an…
31c0ff1 
…d radio button on top

Impacted files:
* `attribute_button.dart`: 2 lines (instead of 1) for "importance", and radio button on top
* `user_preferences_page-blue-dark.png`: golden refresh
* `user_preferences_page-blue-light.png`: golden refresh
* `user_preferences_page-brown-dark.png`: golden refresh
* `user_preferences_page-brown-light.png`: golden refresh
* `user_preferences_page-green-dark.png`: golden refresh
* `user_preferences_page-green-light.png`: golden refresh
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 5, 2022 18:35
M123-dev
M123-dev approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev!
I'll need to add some minor changes as "golden" tests fail because of a "not big enough target" error.

@monsieurtanuki monsieurtanuki mentioned this pull request May 6, 2022
Closed
@monsieurtanuki
feat: openfoodfacts#960 - adjustments after golden and stephanegigandet
0abc679 
Impacted files:
* `attribute_button.dart`: smaller title style, info on the right, minimum target size
* `user_preferences_page-blue-dark.png`: golden refresh
* `user_preferences_page-blue-light.png`: golden refresh
* `user_preferences_page-brown-dark.png`: golden refresh
* `user_preferences_page-brown-light.png`: golden refresh
* `user_preferences_page-green-dark.png`: golden refresh
* `user_preferences_page-green-light.png`: golden refresh
@monsieurtanuki monsieurtanuki merged commit b6e253a into openfoodfacts:develop May 6, 2022
@monsieurtanuki monsieurtanuki linked an issue May 6, 2022 that may be closed by this pull request
Text of settings "Not important", "Very important" in new food preferences settings not shown in full on some phones #1763
Closed
@github-actions github-actions bot mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@monsieurtanuki @M123-dev