-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Scanner improvements #1781
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1781 +/- ##
==========================================
- Coverage 8.86% 6.62% -2.25%
==========================================
Files 161 172 +11
Lines 6623 7809 +1186
==========================================
- Hits 587 517 -70
- Misses 6036 7292 +1256
Continue to review full report at Codecov.
|
Hi @M123-dev & @monsieurtanuki, I have implemented a big part of the improvements for the scanner/camera. Thanks ;) |
After discussing with @teolemon, we will measure if these improvements are enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
As I said before, I don't believe in Isolate
. A lot of trouble, and probably not worth it.
We're not talking about heavy processing that makes the app stutter, we're talking about heavy processing that drains the battery. cf. https://www.youtube.com/watch?v=5AxWC49ZMzs
Besides, tomorrow I travel all day long. It's fair to say that you need someone else to approve (or not) this PR.
@M123-dev Do you have a few minutes to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyy @g123k I just had a look at your code, I didn't studied it and I didn't double checked everything but what I read looks good to me.
But I agree with @monsieurtanuki it doesn't solve battery problems (might even add, as we move data to a different threat) but that's not a reason for me to not merge. It assures smoothness in the smoothie main threat thats great.
Also good that you added haptic feedback, just searched for a issue with that to link to this PR but didn't found one. Wonder why I haven't opened one. I've thought about haptic feedback multiple times already.
} | ||
} | ||
|
||
// ignore: avoid_classes_with_only_static_members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a private empty constructor is better then doing it like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An isolate requires a top-level or static function, that's why :/
Some merge conflicts @g123k |
It should now be OK :) |
@g123k the analyzer goes wild, I guess a file has change or something like that |
This PR contains several improvements for the scanner:
Isolate
high
->medium
)"Adaptive algorithm" :
What's still missing: pause the barcode when scrolling between the carousel's cards.-> Will be implemented in a separated PR