-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Camera ignore turn flash off exception #2228
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2228 +/- ##
==========================================
- Coverage 8.86% 7.79% -1.07%
==========================================
Files 161 181 +20
Lines 6623 9028 +2405
==========================================
+ Hits 587 704 +117
- Misses 6036 8324 +2288
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, besides that it looks good
// Only accepts barcodes on half-top of the image | ||
.where((Barcode barcode) => | ||
(barcode.boundingBox?.top ?? 0.0) <= imageHeight * 0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel comfortable doing this already. I often times have to put the barcode in at least some parts behind the card/lower then the middel
Please do a |
Hi everyone,
When the preview is paused, I force the flash to be turned off.
But if the native part is quicker than the Dart side (camera closed for example), it will trigger an exception.
Instead, we just ignore the error