Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ean - now we display ean8 (and not just ean13) #2596

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • edit_product_page.dart

What

  • To display ean codes in the "edit product" page, we use a package that needs to know the ean format first.
  • So far, we assumed that everything was ean13.
  • Now we support ean8 too.
  • Of course a list of ean types to support would be helpful, with a method to discriminate between them.

Screenshot

ean8 ean13
Capture d’écran 2022-07-14 à 19 11 15 Capture d’écran 2022-07-14 à 19 11 59

Impacted file:
* `edit_product_page.dart`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner July 14, 2022 17:12
@monsieurtanuki monsieurtanuki merged commit 390ea3c into openfoodfacts:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants