Product Page section expanding animation #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class SmoothExpandableCard extends StatelessWidget { | ||
| class SmoothExpandableCard extends StatefulWidget { | ||
| const SmoothExpandableCard({ | ||
| @required this.collapsedHeader, | ||
| this.expandedHeader, |
There was a problem hiding this comment.
We may need a bool collapsed in the constructor as a default value; there might already be an issue about that.
There was a problem hiding this comment.
@monsieurtanuki I don't know if I understood you exactly, do you mean that we can set the startvalue for each widget inindividually, or something else
packages/smooth_ui_library/lib/widgets/smooth_expandable_card.dart
Outdated
Show resolved
Hide resolved
monsieurtanuki
approved these changes
Mar 16, 2021
| children: <Widget>[ | ||
| Container( | ||
| child: collapsed | ||
| ? widget.collapsedHeader |
There was a problem hiding this comment.
Just curious: could we just use one header that works for the collapse and expanded states?
There was a problem hiding this comment.
@monsieurtanuki the expanded header is now only optional, great idea
| ], | ||
| ), | ||
| if (collapsed != true) content, | ||
| header, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #203
Removed collapsed from smooth_card:
smooth_card.dartattribute_list_expandable.dartlist_page.dartpantry_list_page.dartproduct_page.dartsmooth_expandable_card.dart: Added icon animation