fix: loop loading when scanning #2669 #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurtanuki
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Hi @AshAman999!
Sorry about that: as I cannot test the scan part there may be side-effects.
That said, we should probably unify the management of getting/displaying a single product. One day.
So far so good!
g123k
reviewed
Aug 2, 2022
M123-dev
approved these changes
Aug 3, 2022
|
@M123-dev ping |
|
Feel free to also merge your PR's if they are approved @AshAman999 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ScanProductCardLoaderis always called even when there is no other product in scan range, tried looking into past codes, the code was everywhere the same, so doing this small change fixed the problemScreenshot
scanloop.mp4
Fixes bug(s)