fix: #2706 - now we display the "LOG IN!" button only if not logged in #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not logged in Impacted files: * `abstract_user_preferences.dart`: added an "additional subtitle" method, returning a `null` widget by default * `user_preferences_account.dart`: (only) implementation of the "additional subtitle", that displays the "LOGIN!" button, but only if not logged in (that's the issue fix) * `user_preferences_page.dart`: now we let each item decide if there's an additional subtitle to display beyond the list tile (and its layout constraints)
Codecov Report
@@ Coverage Diff @@
## develop #2714 +/- ##
==========================================
- Coverage 8.86% 7.21% -1.65%
==========================================
Files 161 219 +58
Lines 6623 10626 +4003
==========================================
+ Hits 587 767 +180
- Misses 6036 9859 +3823
Help us with your feedback. Take ten seconds to tell us how you rate us. |
AshAman999
approved these changes
Aug 2, 2022
|
Thank you @AshAman999! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
abstract_user_preferences.dart: added an "additional subtitle" method, returning anullwidget by defaultuser_preferences_account.dart: (only) implementation of the "additional subtitle", that displays the "LOG IN!" button, but only if not logged in (that's the issue fix)user_preferences_page.dart: now we let each item decide if there's an additional subtitle to display beyond the list tile (and its layout constraints)What
Screenshot
Fixes bug(s)