Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Splash on Android 24 #2832

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 22, 2022

Pffiou that one was pretty tricky. In our SVG logo, we use a fillType, which is not supported on Android 21-23, causing many issues.

That should be OK now.

https://issuetracker.google.com/issues/157673272#comment7
Will fix #2829

@g123k g123k self-assigned this Aug 22, 2022
@g123k g123k requested a review from a team as a code owner August 22, 2022 20:44
@teolemon
Copy link
Member

Nice catch
3c2b91dd798e3c1d0e2044662275fdb8.gif

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extensive research and changes @g123k

@teolemon teolemon merged commit ab068ed into openfoodfacts:develop Aug 23, 2022
@g123k g123k deleted the logo_android_24 branch September 2, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building failing with new splash screen
2 participants