feat: adding contribution count #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurtanuki
approved these changes
Nov 5, 2022
There was a problem hiding this comment.
Hi @prathamsoni11!
Looks good to me, but not to the analyzer.
Please read my comments and feel free to ignore them (except the one about the mandatory type)
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
| @@ -216,6 +217,33 @@ class _UserPreferencesPageState extends State<UserPreferencesSection> { | |||
| ); | |||
| } | |||
|
|
|||
| Future<int?> _getMyCount( | |||
| final String userId, | |||
There was a problem hiding this comment.
Careful between userId and email: to be tested if it works in both cases.
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
@monsieurtanuki I completed some of your suggestions and pushed the code. |
g123k
requested changes
Nov 5, 2022
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
AshAman999
reviewed
Nov 5, 2022
packages/smooth_app/lib/pages/preferences/user_preferences_account.dart
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3267 +/- ##
===========================================
- Coverage 10.53% 10.52% -0.02%
===========================================
Files 249 249
Lines 12248 12262 +14
===========================================
Hits 1290 1290
- Misses 10958 10972 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Part of