-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added unique id to API Request header. #3675
Conversation
Heyy @abughalib sorry for the late answer, for the UUID, we don't need to generate a UUID. We already have one inside the app. |
@M123-dev |
Codecov Report
@@ Coverage Diff @@
## develop #3675 +/- ##
===========================================
- Coverage 10.41% 10.40% -0.01%
===========================================
Files 273 273
Lines 13801 13806 +5
===========================================
Hits 1437 1437
- Misses 12364 12369 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@abughalib could you update this PR to use the OpenFoodAPIConfiguration uuid. It is persistant |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @abughalib
What
Added a Unique Id to each app installation.
The issue:
Data Source should show who updated something.
So far I have come to 2/3 ways to do this.
The app has a global user and is used when an anonymous user edits the product. Ref: smoothie-app We can create an account on Open Food Facts using UUID for each app installation as a global user (I don't know if it's the right way).
If we store the comments that come with the API Request header. And show them if the user is a 'smoothie-app'.
Ref to the Server Side Template: here And the View
Sorry, I was not able to test if the server-side receives the comments, I tried building the server-side docker container 3 times, twice in Windows 11, and once in Debian 11. I was getting lots of errors.
Part of
#1351
#3644