Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The user's cookie is now stored and passed to the API #5170

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Apr 20, 2024

Hi everyone!

We can now get the user's cookie via the API.
It allows us to send it with the getProduct() method and thus have different KP depending on the connected user.

The idea is to give access to the Nutri-Score v2.
For now, there are only the EN images in cache.

Screenshot 2024-04-19 at 18 15 36

@g123k g123k requested a review from a team as a code owner April 20, 2024 12:01
@g123k g123k linked an issue Apr 20, 2024 that may be closed by this pull request
@g123k g123k changed the title feat; The user's cookie is now stored and passed to the API feat: The user's cookie is now stored and passed to the API Apr 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 9.51%. Comparing base (4d9c7fc) to head (db6c300).
Report is 77 commits behind head on develop.

Files Patch % Lines
..._app/lib/data_models/user_management_provider.dart 12.50% 7 Missing ⚠️
...kages/smooth_app/lib/data_models/login_result.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5170      +/-   ##
==========================================
- Coverage     9.54%   9.51%   -0.04%     
==========================================
  Files          325     327       +2     
  Lines        16411   16579     +168     
==========================================
+ Hits          1567    1578      +11     
- Misses       14844   15001     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

@teolemon teolemon merged commit 321eb9e into openfoodfacts:develop Apr 20, 2024
7 checks passed
@g123k
Copy link
Collaborator Author

g123k commented Apr 20, 2024

Thanks.
I forgot to mention it, but you have to log in again to get the cookie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Cache and Nutri-score v2
3 participants