-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5203 - "add receipt" and "add price tags", even offline or not found #5392
Conversation
…found Impacted files: * `app_en.arb`: added 2 "add" and 4 "price product" labels * `app_fr.arb`: added 2 "add" and 4 "price product" labels * `edit_product_page.dart`: minor refactoring * `get_prices_model.dart`: minor refactoring * `price_amount_card.dart`: added the case of "no product yet" * `price_amount_model.dart`: added "no product yet" check * `price_meta_product.dart`: 2 more cases - "no product yet" and "not found product" * `price_product_list_tile.dart`: minor refactoring * `price_product_search_page.dart`: now we accept "not found" products and we don't force the server lookup * `prices_card.dart`: minor refactoring * `product_price_add_page.dart`: minor refactoring * `user_preferences_account.dart`: added "Add receipt" and "Add price tags"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5392 +/- ##
==========================================
- Coverage 9.54% 7.25% -2.30%
==========================================
Files 325 391 +66
Lines 16411 20078 +3667
==========================================
- Hits 1567 1456 -111
- Misses 14844 18622 +3778 ☔ View full report in Codecov by Sentry. |
@monsieurtanuki @g123k I would like take the occasion to solve the horrendous low connectivity/ airplane mode experience``, not just for prices, but for products. We could have a "Add unselected images" only experience, but we could also try to be useful for regular users. I believe if we want to solve it, we have to write ourselves a script to slice down the daily data exports by country and propose it to the server. That way, we'll know whether the product actually exists (modulo 2000 products added everyday, plus products that are not tagged as sold in your country, plus other edges cases). What do you think? |
Currently, the solution we have in dev mode would bring the server down |
@teolemon I would focus on this PR first, as it is remotely related to offline product scan. Continued conversation in #18 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @monsieurtanuki 👍
What
Screenshots
Et voilà:
Fixes bug(s)
Part of
Impacted files
app_en.arb
: added 2 "add" and 4 "price product" labelsapp_fr.arb
: added 2 "add" and 4 "price product" labelsedit_product_page.dart
: minor refactoringget_prices_model.dart
: minor refactoringprice_amount_card.dart
: added the case of "no product yet"price_amount_model.dart
: added "no product yet" checkprice_meta_product.dart
: 2 more cases - "no product yet" and "not found product"price_product_list_tile.dart
: minor refactoringprice_product_search_page.dart
: now we accept "not found" products and we don't force the server lookupprices_card.dart
: minor refactoringproduct_price_add_page.dart
: minor refactoringuser_preferences_account.dart
: added "Add receipt" and "Add price tags"