Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5556 - try to display the questions when in button mode #5795

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Half the population couldn't see the robotoff questions in the product page.
  • Now they can.

Screenshot

as a "banner" as a "button"
Image Image

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.07%. Comparing base (4d9c7fc) to head (5cd02ad).
Report is 427 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5795      +/-   ##
==========================================
- Coverage     9.54%   7.07%   -2.47%     
==========================================
  Files          325     411      +86     
  Lines        16411   22236    +5825     
==========================================
+ Hits          1567    1574       +7     
- Misses       14844   20662    +5818     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki merged commit 5fb4dc3 into openfoodfacts:develop Nov 6, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Robotoff question not showing up
3 participants