-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The front picture is now fully visible on the product page #5828
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5828 +/- ##
==========================================
- Coverage 9.54% 6.98% -2.57%
==========================================
Files 325 413 +88
Lines 16411 22644 +6233
==========================================
+ Hits 1567 1581 +14
- Misses 14844 21063 +6219 ☔ View full report in Codecov by Sentry. |
I know, there are many commits, but as always, details are details! 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be tempting to remove the background using on device segmentation (MLkit), but that's for another time.
@g123k What's the image ? main product language ? ui language ? any language available if main product language not available ? |
Same as today:
In a second PR, I want to show a message in the photo grid to explain why there is a picture on the product page and not there. Also, a second idea would be to launch the photo grid in a "best world" mode, with photos from any language. |
Hi everyone!
This PR (re)introduces the front picture on the product page, but there are also some tweaks to this page:
Compatibility score
Tooltip
to better explain what it is.
Front picture
The front picture is fully visible and not centered (vs search)
There is a slight border
The quantity is below the brands (and not on the right)
If the front picture is outdated, the indicator is also visible on this page
And there's a
Tooltip
to explainBrands
Error states
If there is no picture available, instead of the blueish placeholder, I've created one with the orange (feel free to add some feedback)
If there is a network error, it's now fully explained
Dark mode
Misc