Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Basic details: explanations about the producer are in a b… #5870

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 16, 2024

Hi everyone!

There's a new Widget available from the POC: SmoothBanner which allows displaying info at the bottom of the screen.
In this PR, there's also an initial implementation with the producer info on Basic details:

Untitled

Note: the UltraBlack color was invalid (fixed ✅)

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0.97087% with 102 lines in your changes missing coverage. Please review.

Project coverage is 6.83%. Comparing base (4d9c7fc) to head (c55f32e).
Report is 481 commits behind head on develop.

Files with missing lines Patch % Lines
..._app/lib/pages/product/add_basic_details_page.dart 0.00% 77 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_banner.dart 0.00% 18 Missing ⚠️
...smooth_app/lib/pages/product/owner_field_info.dart 16.66% 5 Missing ⚠️
.../smooth_app/lib/widgets/v2/smooth_buttons_bar.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5870      +/-   ##
==========================================
- Coverage     9.54%   6.83%   -2.72%     
==========================================
  Files          325     429     +104     
  Lines        16411   23609    +7198     
==========================================
+ Hits          1567    1614      +47     
- Misses       14844   21995    +7151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon requested a review from a team November 17, 2024 14:01
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We will probably to color them for other uses with more urgency in the future.

@g123k
Copy link
Collaborator Author

g123k commented Nov 18, 2024

Looks good to me. We will probably to color them for other uses with more urgency in the future.

This one is more for info.
I think we need something different for alerts.

@teolemon teolemon merged commit c102a0e into openfoodfacts:develop Nov 18, 2024
6 checks passed
@g123k g123k deleted the producer_banner branch November 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants