Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5905 - toggle instead of check box for "discount" price #5930

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Toggle instead of check box for "discount" price

Screenshots

image
image

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 6.57%. Comparing base (4d9c7fc) to head (4b4065a).
Report is 517 commits behind head on develop.

Files with missing lines Patch % Lines
...smooth_app/lib/pages/prices/price_amount_card.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5930      +/-   ##
==========================================
- Coverage     9.54%   6.57%   -2.97%     
==========================================
  Files          325     437     +112     
  Lines        16411   24666    +8255     
==========================================
+ Hits          1567    1623      +56     
- Misses       14844   23043    +8199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @monsieurtanuki

@teolemon teolemon merged commit d4507d0 into openfoodfacts:develop Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Turn the checkbox into a toggle
3 participants