feat(frontend): enable advanced research #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 21, 2024 18:31
Piv94165
changed the title
taxonomy-editor-frontend/src/client/models/EntryNodeSearchResult.ts
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/SearchResults.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/FiltersArea.tsx
Outdated
Show resolved
Hide resolved
| <FiltersArea | ||
| setCurrentPage={setCurrentPage} | ||
| setQ={setQ} | ||
| filters={entryNodeSearchResult?.filters ?? []} |
There was a problem hiding this comment.
This creates weird states: when you go and fetch a new search result, entryNodeSearchResult is set to undefined so the filters are reset during that time
You may want to use placeholderData and isPlaceholderData for this: https://tanstack.com/query/latest/docs/framework/react/guides/migrating-to-v5#removed-keeppreviousdata-in-favor-of-placeholderdata-identity-function
taxonomy-editor-frontend/src/pages/project/search/FiltersArea.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/MultipleSelectFilter.tsx
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/SearchResults.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/SearchResults.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/MultipleSelectFilter.tsx
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/FiltersArea.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The language selection seems super slow... Maybe modifying how the states are handled as suggested in other comments may help
taxonomy-editor-frontend/src/pages/project/search/MultipleSelectFilter.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/MultipleSelectFilter.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/search/ThreeOptionsSwitch.tsx
Outdated
Show resolved
Hide resolved
| /> | ||
| <MultipleSelectFilter | ||
| label="Translated into" | ||
| filterValue={chosenLanguagesCodes} |
There was a problem hiding this comment.
I'm not sure why you do not pass the setFilterValue function to this component whereas you do that in other places
There was a problem hiding this comment.
Currently, the filterValue state in the MultipleSelectFilter component is updated based on the response from the backend. However, MultipleSelectFilter only updates the query (Q) sent to the backend. Upon reflection, I realize that both filterValue and setFilterValue from FilterInput should be maintained as component states rather than passed as props.
* feat(frontend): make language selection for translations more intuitive (#461) The PR modifies the translations section of the edit entry page: * Changes "All languages" terminology to "Fallback translations" (fixes #458) * Adds an info alert if "en" (English) or "xx" (Fallback translations) is not the main language for an entry (fixes #457) / Fixes the fact that the alert message about changing the display name of a language appears even if the language had no translations and we add the first one (fixes #459) * Adds a "Show all existing translations" checkbox to see all the languages that currently have translations, with their translations Adds a possibility to "pin" languages to select them (so they stay in local storage and appear at the top for each entry), and a possibility to hide (unselect) these languages easily (with an icon next to their title) * Modifies the selection of new languages: I removed the "number of languages shown" button that had to be clicked to add a language, and created a "Show another language" button at the bottom of the section. Also, the dialog is now an autocomplete instead of a select, and you just type the languages that you want to add and see languages that are not selected, instead of seeing all current languages and being able to remove them. The autocomplete with the options is also automatically focused when opening the dialog. * Adds vite-plugin-svgr to easily import svg files in React --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> * feat: add property filter to search API (#456) * feat: add property filter to search API * chore: generate SDK * chore: Add info banners on the frontend (#473) * docs: add info banners * refactor: delete unnecessary components * fix: add line break * improve search results, and few other improvements * show translations instead of translated languages --------- Co-authored-by: Charles Perier <charlesperier@Charless-Laptop.local> Co-authored-by: Eric Nguyen <ericnguyen.developper@gmail.com>
eric-nguyen-cs
approved these changes
Apr 11, 2024
Comment on lines
6
to
7
| // filterValue: string; | ||
| // setFilterValue: Dispatch<SetStateAction<string>>; |
There was a problem hiding this comment.
Suggested change
| // filterValue: string; | |
| // setFilterValue: Dispatch<SetStateAction<string>>; |
Comment on lines
15
to
16
| // filterValue, | ||
| // setFilterValue, |
There was a problem hiding this comment.
Suggested change
| // filterValue, | |
| // setFilterValue, |
added 2 commits
April 11, 2024 11:13
…ithub.com/openfoodfacts/taxonomy-editor into piv94165/frontend-advanced-research-merge
added 3 commits
April 11, 2024 11:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
EntryNodeswith filters (example:is:root ancestor:en:ghee dairyordescendant:en:dairy language:fr not(language):fr), full-text-search.Possible evolutions
is:modified property:vegan:en:no not(property):description:en)Screenshot
advanced-research-V3.mp4