Apply suggestions from code review

Co-authored-by: Maikel <maikel@email.org.au>
openfoodfoundation · Jan 22, 2025 · ff3af2f · ff3af2f
1 parent 00b78f4
commit ff3af2f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/admin/dfc_product_imports_controller.rb b/app/controllers/admin/dfc_product_imports_controller.rb
@@ -38,8 +38,8 @@ def index
     rescue Rack::OAuth2::Client::Error => e
       flash[:error] = I18n.t(
         'admin.dfc_product_imports.index.oauth_error_html',
-        message: ActionController::Base.helpers.sanitize(e.message),
-        oidc_settings_link: ActionController::Base.helpers.link_to(
+        message: helpers.sanitize(e.message),
+        oidc_settings_link: helpers.link_to(
           I18n.t('spree.admin.tab.oidc_settings'), Rails.application.routes.url_helpers.admin_oidc_settings_path
         )
       ).html_safe

diff --git a/engines/dfc_provider/app/services/dfc_request.rb b/engines/dfc_provider/app/services/dfc_request.rb
@@ -86,6 +86,6 @@ def refresh_access_token!
         token: nil,
         refresh_token: nil
       )
-      throw e
+      raise
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,6 +86,6 @@ def refresh_access_token! @@
             token: nil,
             refresh_token: nil
           )
-          throw e
+          raise
       end
     end