Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vertical transitions for cloning and deleting products #12691

Conversation

ccozkan
Copy link
Contributor

@ccozkan ccozkan commented Jul 22, 2024

What? Why?

Changes slide in and slide out effects so that it is appearing and disappearing from top

Peek 2024-07-22 05-44

What should we test?

Described on #12624

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@ccozkan ccozkan force-pushed the use-vertical-transitions-for-cloning-and-deleting branch from ea04be5 to 29d63b0 Compare July 22, 2024 03:01
Copy link
Collaborator

@chahmedejaz chahmedejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍 Thanks 🎉

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@drummer83 drummer83 self-assigned this Jul 28, 2024
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Jul 28, 2024
@drummer83
Copy link
Contributor

Hi @ccozkan,
Thank you for this PR. I have tested it on our staging server.

Before your PR

Kazam_screencast_00006.webm

After your PR

Kazam_screencast_00007.webm

Conclusion

It's looking good! Thank you again!
Merging! 🚀

@drummer83 drummer83 merged commit 00a0006 into openfoodfoundation:master Jul 28, 2024
52 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Jul 28, 2024
@ccozkan ccozkan deleted the use-vertical-transitions-for-cloning-and-deleting branch July 28, 2024 23:33
@filipefurtad0 filipefurtad0 added the user facing changes Thes pull requests affect the user experience label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUU] Use vertical transitions for cloning and deleting products
5 participants