Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert product description truncation fix #12694

Conversation

rioug
Copy link
Collaborator

@rioug rioug commented Jul 22, 2024

What? Why?

Product description is displaying wrong on safari Iphone, reverting #12635 as a quick fix

What should we test?

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

It breaks wit Safari on Iphone
@dacook dacook added bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. user facing changes Thes pull requests affect the user experience labels Jul 22, 2024
@filipefurtad0 filipefurtad0 self-assigned this Jul 22, 2024
@filipefurtad0 filipefurtad0 added the pr-staged-fr staging.coopcircuits.fr label Jul 22, 2024
@filipefurtad0
Copy link
Contributor

Hey @rioug ,

Thanks for reverting this.

Ok, finally was able to reproduce the issue. On master, currently (it's the double spacing from external office software):

image

After this PR:

image

Merging.

@filipefurtad0 filipefurtad0 merged commit 146296d into openfoodfoundation:master Jul 22, 2024
57 checks passed
@filipefurtad0 filipefurtad0 removed the pr-staged-fr staging.coopcircuits.fr label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Product description displaying jumbled or overlapping lines
3 participants