fix rubocop Rails/ResponseParseBody

[Yassir4]

What? Why?

• Closes Rubocop Rails/ResponseParsedBody #12620
• Fixes the RuboCop Rails/ResponseParsedBody

Note

I disabled the RuboCop check on the spec/controllers/user_registrations_controller_spec.rb because the response is returned using format.js not format.json which doesn't work well with the parsed_body method.

What should we test?

• Manual test for successful user registration/signup. Check JS console in case of any errors/warnings.
• Test should pass for the spec file changed

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[rioug]

Thanks @Yassir4 🙏 !

I disabled the RuboCop check on the spec/controllers/user_registrations_controller_spec.rb because the response is returned using format.js not format.json which doesn't work well with the parsed_body method.

It looks like something that should be using format.json and that we should fix, Would you want to give this a go ?

[dacook]

It looks like something that should be using format.json and that we should fix

Agreed, this should be fixed if possible.

Alternatively, we shouldn't disable the rubocop rule here. It's a violation that is still "to do"

[Yassir4]

@rioug @dacook

I will tackle it.

The UserRegistrationsController#create is not yet used for signup, I saw an open issue for merging Spree::UserRegistrationsController into UserRegistrationsController, so changing the format won't break anything

[rioug]

Awesome ! thank you @Yassir4 🙏
FYI for next time, we tend to prefer rebasing the branch on master, rather than merging master.

[dacook]

Thank you! I've added a testing note to check the user registration.

[filipefurtad0]

Hey @Yassir4,

Thanks for this PR as well. (Thank you @dacook for the notes on what to test).
I have not spotted any new errors on the console, when registering a new user - those on the picture are pre-existent (those appearing on Stripe are intermittent and I don't think relate to this PR):

Before this PR

After this PR

All working as before. Merging.