Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'reply to' email address where it makes sense and has been missing #13139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drummer83
Copy link
Contributor

This includes the following emails:

  • Manager invitation email: reply to inviting enterprise
  • Authorize payment email: reply to distributor
  • Order cancellation email: reply to distributor
  • Shipment notification email: reply to distributor

What? Why?

What should we test?

  • Make sure the following emails are still sent and ok:
    • Manager invitation email
    • Welcome email for enterprises ("Enterprise XY is now on Open Food Network")
    • Order cancellation email for customer
    • Order cancellation email for shop
    • Order confirmation email for customer
    • Order confirmation email for shop
    • Invoice email for customer
    • Authorize payment email for customer (stripe payment)
    • Authorization required email for shop (for subscription orders)
    • Shipment notification email for customer
  • Make sure the following emails still have the same reply-to email address:
    • Welcome email for enterprises ("Enterprise XY is now on Open Food Network")
    • Order cancellation email for shop
    • Order confirmation email for customer
    • Order confirmation email for shop
    • Invoice email for customer
    • Authorization required email for shop (for subscription orders)
  • Make sure the following emails have a new reply-to email address:
    • Manager invitation email -> inviting enterprise's email
    • Order cancellation email for customer -> distributor's email
    • Authorize payment email for customer (stripe payment) -> distributor's email
    • Shipment notification email for customer -> distributor's email

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@drummer83 drummer83 self-assigned this Feb 10, 2025
@drummer83 drummer83 force-pushed the reply-to-email-address branch from 2206c57 to e0b9cdf Compare February 10, 2025 20:40
…ing until now

This includes the following emails:

Manager invitation email: reply to inviting enterprise

Authorize payment email: reply to distributor

Order cancellation email: reply to distributor

Shipment notification email: reply to distributor
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thanks @drummer83 🙏

@rioug rioug added the user facing changes Thes pull requests affect the user experience label Feb 10, 2025
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tschumilas
Copy link

What about when a distributor sends invoices? these come from the platform configured no-reply email now I believe. Could these also have the distributor's email as the reply to email? (maybe I'm misunderstanding something here)

@filipefurtad0 filipefurtad0 self-assigned this Feb 14, 2025
@filipefurtad0 filipefurtad0 added pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-au staging.openfoodnetwork.org.au labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Test Ready 🧪
Development

Successfully merging this pull request may close these issues.

Change reply-to email address on shipment & order confirmation emails
5 participants