Update line items enterprise fee instead of deleting and recreating #13144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed to clear_order_adjustments, it doesn't clear line item adjustment
We now update or create line item fees instead of deleting them and recreating them. This is to cover the case when a product has been removed from an Order Cycle but we want to keep the fee already applied on existing order. This was an issue only if the existing order got updated after the product was removed.
Spree::Order just delegate Orders::HandleFeesService so there is no point testing fees in the order spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Currently when an order gets updated all enterprise fees are deleted and recreated to ensure it's up to date. This is an issue when a product has been removed from an Order Cycle, any subsequent update to the order will remove fees associated with said product. To prevent this, we now create or update per item enterprise fees, per order fee are still deleted and recreated.
An easier way to fix the issue is to assume any product in the order are from the Order Cycle linked to the order, so we could keep the delete and recreate solution. However, currently Order Cycle are not mandatory on the Order, and there is no check to ensure a product is the Order Cycle when adding/updating an order.
What should we test?
In general we want to test that enterprise fee per item are working as before
As an enterprise manager :
TODO simple order cycle add scenario
As a customer
As an enterprise manager:
Search for the just placed order and open the edit page
ensure both fees were applied
remove on outgoing variant
on the order edit page, Click on "update and recalculate fees!"
check the outgoing fee is still present
remove the incoming variant
on the order edit page, Click on "update and recalculate fees!"
check the incoming fee is still present
remove fee from the Order Cycle, stay there
add a new fee -> gets added to product even removed onec
delete fee -> fee still there
update removed product quantity -> fee gets updated
customer edit order -> fee don't disappear
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates