Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): update typing on web side for signIn function #12

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

PaulPaulDevelops
Copy link
Member

Description

Met with @Ricardo385 to discuss typing on the web side. Add adjustments and to-dos for future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation Update (JS Docs)

General Checklist (every PR)

Please CHECK the box you took the step! Otherwise review should assume you missed it and fail the PR

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Sorry, something went wrong.

Copy link
Collaborator

@Ricardo385 Ricardo385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@Ricardo385 Ricardo385 changed the base branch from main to development September 18, 2023 14:50
@Ricardo385 Ricardo385 merged commit 7748ae3 into development Sep 18, 2023
@PaulPaulDevelops PaulPaulDevelops deleted the fix/web-type-sign-up branch September 18, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants