Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share initial gee assets on AssetSelect widget #931

Closed
dfguerrerom opened this issue Aug 19, 2024 · 1 comment
Closed

share initial gee assets on AssetSelect widget #931

dfguerrerom opened this issue Aug 19, 2024 · 1 comment
Assignees

Comments

@dfguerrerom
Copy link
Collaborator

While testing AssetSelect performance, I noticed that it was taking way too long to load the component, and it is because of two reasons:

  • the component requests all the user assets by calling a recursive function, this is good, but when the user has several folders, the process takes more time.

  • the component observes the types traitlet with the decorator, this causes a double call of the _get_items() function:

    • the first happens at the initialization stage with _get_items and the second happens when the type trait changes from empty to the default, that can easily be fixed if we observe at the init function instead of using the decorator.
  • finally, the problem is even worst if we create apps with more than one AssetSelect component, since it will do the same operation several times.

this is also related to: #455

@dfguerrerom
Copy link
Collaborator Author

closed by #932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant