Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store initial assets in class variable #932

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

dfguerrerom
Copy link
Collaborator

this PR creates a new mutable class member _initial_assets: list which will be filled with a list of assets after the first instance creation of the AssetSelect. This member will be checked before running the ee.data.listassets call to earthengine, if the member has already data, the elements will use their data instead.

I also moved the decorator as I proposed in #931

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (776f019) to head (5fcd958).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   96.76%   96.77%           
=======================================
  Files          39       39           
  Lines        3960     3964    +4     
=======================================
+ Hits         3832     3836    +4     
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfguerrerom dfguerrerom merged commit c67211e into main Aug 20, 2024
8 of 9 checks passed
@dfguerrerom dfguerrerom deleted the asset_select branch August 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants