Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closes #838. remove inline js comments #840

Merged
merged 6 commits into from
Jun 20, 2023
Merged

fix: closes #838. remove inline js comments #840

merged 6 commits into from
Jun 20, 2023

Conversation

dfguerrerom
Copy link
Collaborator

The problem here (after many wasted hours) was that we're reading the js files as text and so, apparently, the inline comments had a conflict with the js script, I have wrapped the comments with /* ...*/ and apparently it works now.

aims to replace #839.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #840 (fcc13d5) into delete-folder (29389fc) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           delete-folder     #840   +/-   ##
==============================================
  Coverage          96.54%   96.54%           
==============================================
  Files                 39       39           
  Lines               3790     3790           
==============================================
  Hits                3659     3659           
  Misses               131      131           
Impacted Files Coverage Δ
sepal_ui/aoi/aoi_tile.py 100.00% <ø> (ø)
sepal_ui/frontend/resize_trigger.py 100.00% <ø> (ø)
sepal_ui/frontend/styles.py 100.00% <ø> (ø)
sepal_ui/mapping/fullscreen_control.py 100.00% <ø> (ø)
sepal_ui/mapping/layer_state_control.py 98.00% <ø> (ø)
sepal_ui/mapping/legend_control.py 93.65% <ø> (ø)
sepal_ui/mapping/menu_control.py 100.00% <ø> (ø)
sepal_ui/mapping/zoom_control.py 100.00% <ø> (ø)
sepal_ui/model/model.py 100.00% <ø> (ø)
sepal_ui/planetapi/planet_widgets.py 100.00% <ø> (ø)
... and 18 more

@dfguerrerom dfguerrerom marked this pull request as ready for review June 20, 2023 14:17
@dfguerrerom dfguerrerom changed the base branch from main to delete-folder June 20, 2023 15:14
@dfguerrerom
Copy link
Collaborator Author

@12rambau I noticed you had changed the failing test on the delete_folder branch, so I have changed the base branch to merge with that one, fixing the conflict.

Base automatically changed from delete-folder to main June 20, 2023 17:26
Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are mixed commits from other PR but this will be solved when merged

@12rambau 12rambau merged commit 5277a82 into main Jun 20, 2023
@12rambau 12rambau deleted the js_fix2 branch June 20, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants