-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: closes #838. remove inline js comments #840
Conversation
Codecov Report
@@ Coverage Diff @@
## delete-folder #840 +/- ##
==============================================
Coverage 96.54% 96.54%
==============================================
Files 39 39
Lines 3790 3790
==============================================
Hits 3659 3659
Misses 131 131
|
@12rambau I noticed you had changed the failing test on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are mixed commits from other PR but this will be solved when merged
The problem here (after many wasted hours) was that we're reading the js files as text and so, apparently, the inline comments had a conflict with the js script, I have wrapped the comments with /* ...*/ and apparently it works now.
aims to replace #839.