-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add setup argument to listen on specific ip (#7574)
- Loading branch information
Showing
2 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b5632a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the option to specify the address, but I don't agree with the parameter order where it becomes
setup(port, host)
-- it is much more common to have host followed by port, and ofxOscSender uses that order; this creates an unusual usage exception.since the current behaviour is a single int arg for the port, a new setup method :
could be introduced without generating conflicts (and the default ="0.0.0.0" is then not needed because if you use this version of setup, it is explicitly because you want to set a host. and the old setup(int port) then simply calls this setup with 0.0.0.0 as the addr)