made keyboard orientation fixes #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| case OF_ORIENTATION_DEFAULT: | ||
| x = rect.origin.x; | ||
| y = rect.origin.y;//-rect.size.height; |
There was a problem hiding this comment.
is this being commented out intentional?
I just wanted to double check.
thx!
There was a problem hiding this comment.
Yeah, I noticed the position of the rectangle was wrong for default portrait orientation. It was positioning from bottom left instead of top left. I've tested all 6 orientations and now they are all consistent. Sorry, I should have removed the commenting out bit. At least you know why now- should i update?
|
great thanks @trentbrooks |
ofTheo
added a commit
that referenced
this pull request
Jul 31, 2014
made keyboard orientation fixes
This was referenced Jul 31, 2014
MartinHN
pushed a commit
to MartinHN/openFrameworks
that referenced
this pull request
Dec 16, 2014
…rd-orientation made keyboard orientation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS keyboard orientation fixes as described here #2621