ofEasyCam: fixes floating point errors in rotation + events priority #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturoc
added a commit
that referenced
this pull request
Jul 30, 2014
ofEasyCam: fixes floating point errors in rotation + events priority
|
Just curious, why do they need to be outside the class? |
|
no need, they were declared out of the class before. I just changed them to make them static so they don't exist out of that file. Doesn't make any difference to declare them in or out the class really as long as they are static but feel free to change them |
MartinHN
pushed a commit
to MartinHN/openFrameworks
that referenced
this pull request
Dec 16, 2014
ofEasyCam: fixes floating point errors in rotation + events priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this problem: http://forum.openframeworks.cc/t/ofeasycam-roll-when-dragging-problem/14424/6 which was caused from calculating the rotation from the difference with the last mouse position which introduced small floating point errors on every update. Calculating the rotation from the difference of the mouse position when it's pressed and the current removes the precision errors and fixes the problem.
Also starts the movement on the mouse events so other code like guis can intercept the event and the camera won't move while moving a slider for example