ofFileUtils: low_level_docs & api updates #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you deprecate setReadOnly with a message asking to use setWritable instead of completely remove it? also if you can change the test that is currently failing to use the new method instead? |
|
sure thing |
…Utils test to use setWriteable() instead of setReadOnly()
|
Updated. |
arturoc
added a commit
that referenced
this pull request
Mar 9, 2016
ofFileUtils: low_level_docs & api updates
|
thanks! |
This was referenced Mar 9, 2016
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for fixes related to #4951 & #4931
I would have done this sooner but we decided to head to the mountains last weekend. I think everyone should :)