fix conflicting declaration OpenGL on some linux distros
#6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturoc
reviewed
Nov 23, 2018
| @@ -209,7 +209,7 @@ enum ofTargetPlatform{ | |||
| #define GL_GLEXT_PROTOTYPES | |||
| #include <GL/glew.h> | |||
| #include <GL/gl.h> | |||
There was a problem hiding this comment.
can you comment this line as well? also for osx and windows can you comment out the includes for GL/* except glew to see what happens?
There was a problem hiding this comment.
comment line :211 also no issue.
I'm not sure on other OS (osx/windows). but I'll test and post here later.
no issue on linux.
icq4ever
commented
Nov 23, 2018
no issue on MacOS 10.14.1 Mojave
|
hey thanks, you can just comment the rest of the platforms out (only desktop though) and the ci servers we'll test if everything keeps compiling or not |
|
cool. I cannot find proper line for windows. I think it's done. |
|
thanks! |
|
can this get into master as well? |
|
it is already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported from here.
https://forum.openframeworks.cc/t/arch-linux-compilation-error-after-updating-the-system/31097
and solution?.
mupen64plus/mupen64plus-video-z64#16