Updated examples to glm

[roymacdonald]

I made a big mistake with git and the easiest way to fix it was to get simply copy all the modified examples over the master and commit and PR again.
@bakercp

[bakercp]

Review complete. Changes submitted via PR.

[roymacdonald]

seems to be ok then to merge. the CI is passing. @arturoc does the CI compile the examples?
I will double check visually each example though. @bakercp did you visually check the iOS examples?
I'll try yo get android running again to visually check too.

[roymacdonald]

ok

[bakercp]

My visual inspection of the iOS examples was successful. As soon as we figure out the quaternion issue #6327 and confirm android, I think this is ready to go.

[roymacdonald]

good, I hope we get the ofQuat issue solved soon. I will check androind over the next days and report back.

[ofTheo]

@bakercp is there anything else left? #6327 is closed now.

[bakercp]

@ofTheo @roymacdonald Roy -- did you make the glm::rotation changes? I can't seem to find them in this PR.

[roymacdonald]

@bakercp Nope. This function we found that glm has it does not act in the same way as the ofQuaternion. I was testing it while in Denver, I'll look at it again tomorrow. But i think that it is fine to merge all this as-is, and then I make a different PR with the fixed orientation example.

[ofTheo]

@roymacdonald sounds good. Are you able to make the changes I mentioned above?
I think it would be good to have them made to your branch before we merge.

Basically avoid empty constructors that don't set initial values as that will give undefined results.

[roymacdonald]

@ofTheo sorry but I am not following. which changes did you mention? Where are those empty constructors?

[ofTheo]

sorry @roymacdonald I think my review requesting changes wasn't public. see above! Thanks!

[ofTheo]

ps: @roymacdonald

I think glm::rotation is a 1:1 replacement for ofQuaternion::makeRotate

Here is a quick example that switches between the two.
It seems identical to me. Let me know if I am missing something :)

ofEasyCam cam;

//--------------------------------------------------------------
void ofApp::draw(){
    ofEnableLighting();
    ofLight l1;
    l1.setPosition(300, 300, 300);
    l1.enable();
    ofEnableDepthTest();
    
    cam.begin();
    
        ofQuaternion q;
        q.makeRotate(glm::vec3(0, 1, 0), glm::vec3(1, 0, 0));
        
        glm::quat qGLM = q;
        if( ofGetSeconds() % 2 == 0 ){
            glm::quat qGLM = glm::rotation(glm::vec3(0, 1, 0), glm::vec3(1, 0, 0));
        }
        
        ofMultMatrix( glm::toMat4(qGLM) );
        
        ofDrawCone(glm::vec3(0), 50, 300);
    cam.end();
}

[roymacdonald]

@ofTheo @bakercp I've updated the orientation example as well as the glm constructor issue that theo mentioned. I don't know if there are more issues with this glm constructor thing.

[ofTheo]

Thanks @roymacdonald !
As far as I can tell this looks good to merge.

[roymacdonald]

Super. Now on what does it depend to get it merged?

[arturoc]

thanks roy!

[bakercp]

Epic. Thanks @roymacdonald !

[ofZach]

👏👏 thx 👏👏