update ofRandomSeed in examples and tests #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 tasks
ofTheo
reviewed
Aug 30, 2023
| @@ -17,7 +17,8 @@ void swarm::init(int nParticles, float positionDispersion, float velocityDispers | |||
| particles.clear(); | |||
| } | |||
|
|
|||
| ofSeedRandom(); | |||
| // ofSeedRandom(); superfluous -- the current random engine state | |||
| // is indistinguishable from another arbirarilty-seeded state | |||
There was a problem hiding this comment.
Agree. Feel free to remove. No need for commenting out :)
ofTheo
reviewed
Aug 30, 2023
| @@ -56,7 +56,8 @@ void Swarm::init(int _nParticles, float positionDispersion, float velocityDisper | |||
| // INITIALISE VALUES | |||
| /////////////////////////////////////////// | |||
| // | |||
| ofSeedRandom(); | |||
| // ofSeedRandom(); superfluous -- the current random engine state | |||
| // is indistinguishable from another arbirarilty-seeded state | |||
| // | |||
There was a problem hiding this comment.
Agree. Feel free to remove. No need for commenting out :)
ofTheo
reviewed
Aug 30, 2023
tests/addons/networkTcp/src/main.cpp
Outdated
| @@ -257,7 +257,7 @@ class ofApp: public ofxUnitTestsApp{ | |||
| } | |||
|
|
|||
| void run(){ | |||
| ofSeedRandom(ofGetSeconds()); | |||
| ofSetRandomSeed(ofGetSeconds()); // why? random engine is initialized to a non-deterministic state | |||
|
done! |
|
Thanks!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.