Removal of FMOD linking and dylib copying on osx, since it is not being used #8152
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 For moving FMOD out of the core either to an add on or removing it all together. |
|
Let's do it! Oh yes - and it's an oldey in the 3 digits!! #167 |
|
only took 14 years ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FMOD is NOT being used on osx and still the dylib is being linked and copied into the app's bundle.
this PR removes such.
It is not only disabled by default, it is not possible to enable simply by modifiing the Project.xconfig file as OF_NO_FMOD is being defined in ofConstants.h . Even if I wanted to use FMOD, it will not be that straight forwards.
OF_NO_FMOD defined in ofConstants.h is not the same as the one that is read by xcode_project.sh. The one that the latter reads is the one defined in Project.xcconfig, that is why it needs to be set in it.
This will not break anything as not using FMOD is the default behaviour and not really possible to change by just passing a flag.
Although, I think it is still reasonable to keep the dylib in the core for legacy purposes. (Eventually we should move it into an addon with all fmod related classes)
I guess that it was supposed to be the same variable but it is not.