Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added version option #249

Merged

Conversation

thomasgeissl
Copy link
Contributor

hey @ofTheo,
here without the formatting.

@thomasgeissl
Copy link
Contributor Author

here for reference the old PR, with formatting accidentally turned on.
#242

@ofTheo
Copy link
Member

ofTheo commented Aug 5, 2020

thanks @thomasgeissl !

@ofTheo ofTheo merged commit da2db02 into openframeworks:master Aug 5, 2020
@thomasgeissl
Copy link
Contributor Author

probably it makes sense to display the version on the frontend.

@ofTheo would be possible to tag the release then and upload a signed version to the github releases or the oF ci servers. That would make it much easier to automate things for me with the package manager, e.g. make it installable via brew.

@thomasgeissl thomasgeissl deleted the feature/version-noformatting branch August 5, 2020 21:21
@ofTheo
Copy link
Member

ofTheo commented Aug 5, 2020

@thomasgeissl I think the versions used for releases are automatically archived here:
http://ci.openframeworks.cc/projectGenerator/

It might be possible to automatically add them to the GitHub releases via their api but I haven't tried to do anything like that yet. Would the above link work for your needs? I believe the osx PG app is signed via the CI.

@thomasgeissl
Copy link
Contributor Author

that should work.
but now the versions do not necessarily match with the oF versions as we discussed here.
#242 (comment)

i guess compiling and signing on travis and automatically deploy if a commit is tagged is too much work for now. but i think we should at least tag the releases on github, then we can use features like the rss feed.
https://github.com/openframeworks/projectGenerator/releases.atom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants