V82 - Simplify Local SDK Frameworks handling in osx #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, will this also sort not adding the XCFrameworks to the project view. Just adding as XCFRAMEWORKS search path not doing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR simplifies local SDK Frameworks handling, point them to be relative to the correct SDK Folder set by the project.
it merges the almost similar functions to add .framework and .xcframework to be parsed in the same recursive iteration in all folders.
We can now pass system frameworks (SDK) as a parameter for a specific project in PG, so we can experiment per project
-f"Vision,MetalKit,Metal"