Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local addons ok #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Local addons ok #595

wants to merge 1 commit into from

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 26, 2024

I'm now working on this issue #580
I've noticed it is mostly working after @roymacdonald PR,
but it enforces using ./ in the start of the path, like

./addons/ofxMidi
etc

this PR allows addons to be added like

addons/ofxMidi
addons/ofxTetris

and also removes the function cleanName.
This function actually parses a commented out line like #ofxSyphon, removes the comment and add the addon back which contradicts the person original intention.

@dimitre dimitre marked this pull request as ready for review November 27, 2024 00:00
@roymacdonald
Copy link
Contributor

and also removes the function cleanName.
This function actually parses a commented out line like #ofxSyphon, removes the comment and add the addon back which contradicts the person original intention.

The purpose of this is to be able to have extra information of an addon in the form of a comment and not loosing that. For example, there is a very nice "Package Manager" made by @thomasgeissl which relies on this feature, where it encodes as a comment the version or commit of an addon, so you can then have that. I am not sure if I implemented it all but the idea is that you dont remove the comments from the addons.mk file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants