✨(models) add xAPI Profile model #415
Draft
+692
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioSim
force-pushed
the
xapi-profile-validator
branch
5 times, most recently
from
dc207cf
to
25eeca9
Compare
wilbrdt
reviewed
Aug 24, 2023
src/ralph/models/xapi/profile.py
Outdated
|
|
||
|
|
||
| class ProfilePattern(BaseModel): | ||
| """Profile `patters` field. |
There was a problem hiding this comment.
Suggested change
| """Profile `patters` field. | |
| """Profile `pattern` field. |
There was a problem hiding this comment.
Well spotted! Thanks)
| Attributes: | ||
| id (URI): A URI for the Pattern. | ||
| type (str): Equal to `Pattern`. | ||
| primary (bool): Only primary Patterns are checked for matching sequences of |
There was a problem hiding this comment.
Couldn't we add a custom validator checking that if the pattern is primary, it must include a prefLabel and definition?
SergioSim
force-pushed
the
xapi-profile-validator
branch
from
25eeca9
to
ee493cc
Compare
We want to support xapi profile validation in Ralph. Therefore we implement the xAPI Profile model which should follow the xAPI profiles structures specification.
SergioSim
force-pushed
the
xapi-profile-validator
branch
from
ee493cc
to
0c43770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to support xAPI profile validation in Ralph.
Proposal