Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Email Migration #118

Closed
thomas-kl1 opened this issue Jan 7, 2022 · 0 comments · Fixed by #121
Closed

[BUG] Email Migration #118

thomas-kl1 opened this issue Jan 7, 2022 · 0 comments · Fixed by #121
Assignees
@thomas-kl1
Labels
bug Something isn't working fixed Issue has been fixed
Milestone
Next Release

Comments

@thomas-kl1
Copy link
Member

Description

https://devdocs.magento.com/guides/v2.4/frontend-dev-guide/templates/template-email-migration.html

As of Magento 2.3.4, custom email templates are only allowed to use scalar values for variable data. Direct calls to methods are no longer allowed. To be more specific, methods can no longer be called from variables from either the var directive or when used as parameters. For example {{var order.getEmailCustomerNote()}} or {{something myVar=$obj.method()}} will fail to resolve.

Prerequisites

Magento Version:

  • =2.3.4

Module Version:

  • any that match Magento >= 2.3.4
@thomas-kl1 thomas-kl1 added the bug Something isn't working label Jan 7, 2022
@thomas-kl1 thomas-kl1 added this to the Next Release milestone Jan 7, 2022
@thomas-kl1 thomas-kl1 self-assigned this Jan 7, 2022
@elisei elisei mentioned this issue Apr 28, 2022
Closed
elisei added a commit to elisei/magento2-gdpr that referenced this issue Apr 28, 2022
@elisei
Fix opengento#118 and opengento#120
f8ecff1
@thomas-kl1 thomas-kl1 linked a pull request Apr 28, 2022 that will close this issue
Fix #118 and #120 #121
Merged
elisei added a commit to elisei/magento2-gdpr that referenced this issue Apr 28, 2022
@elisei
Fix opengento#118 and opengento#120
7312da8
thomas-kl1 added a commit that referenced this issue Apr 29, 2022
@thomas-kl1
Merge pull request #121 from elisei/master
4ef6b09 
Fix #118 and #120
@thomas-kl1 thomas-kl1 added the fixed Issue has been fixed label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-kl1 thomas-kl1

Labels
bug Something isn't working fixed Issue has been fixed
Projects
None yet
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Fix #118 and #120 elisei/magento2-gdpr
1 participant
@thomas-kl1