Feature/front snowfall #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComteDeX
force-pushed
the
feature/front-snowfall
branch
from
8d2f7aa to
7f18eb8
Compare
ComteDeX
force-pushed
the
feature/front-snowfall
branch
from
7f18eb8 to
e9f3b79
Compare
thomas-kl1
requested changes
Mar 19, 2022
There was a problem hiding this comment.
@ComteDeX il est découragé de faire des blocks. Il est recommandé d'utiliser des viewModels plutôt
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
@ComteDeX il est découragé de faire des blocks. Il est recommandé d'utiliser des viewModels plutôt
Comment on lines
+2
to
+7
| <!-- | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| --> |
There was a problem hiding this comment.
utiliser la licence opengento (voir les autres fichiers)
| <referenceContainer name="after.body.start"> | ||
| <block | ||
| name="snowflake" | ||
| class="Opengento\Snowflake\Block\Snowflake" |
There was a problem hiding this comment.
ne pas utiliser de block custom mais plutôt un viewModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Front Snowflakes