Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRS optional with default to OGC:CRS84 #60

Merged
merged 11 commits into from
Apr 18, 2022
Merged

CRS optional with default to OGC:CRS84 #60

merged 11 commits into from
Apr 18, 2022

Conversation

alasarr
Copy link
Collaborator

@alasarr alasarr commented Apr 11, 2022

This PR aims to find a solution to the discussion of CRS #52.

It converts the CRS into optional and set the default value to OGC:CRS84.

format-specs/geoparquet.md Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
examples/example.py Outdated Show resolved Hide resolved
@alasarr alasarr changed the title CRS optional with default to OGC:84 CRS optional with default to OGC:CRS84 Apr 12, 2022
```

Due to the large number of CRSes available and the difficulty of implementing all of them, we expect that a number of implementations will at least start with only supporting a single CRS. To maximize interoperability we strongly recommend GeoParquet tool providers to always implement support for [EPSG:4326](https://epsg.org/crs_4326/WGS-84.html).
Users are recommended to store their data in EPSG:4326 for it to work with the widest number of tools. But data that is better served in particular projections can choose to use an alternate coordinate reference system. We expect many tools will support alternate CRSes, but encourage users to check.
Due to the large number of CRSes available and the difficulty of implementing all of them, we expect that a number of implementations will at least start with only supporting a single CRS. To maximize interoperability we strongly recommend GeoParquet tool providers to always implement support for [OGC:CRS84](http://www.opengis.net/def/crs/OGC/1.3/CRS84).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a working https link. Let's use that instead.

https://www.opengis.net/def/crs/OGC/1.3/CRS84

Offtopic: I noticed that the XML definition files point to the http links (for example https://www.opengis.net/def/crs/OGC). Does anyone know why and if it's possible to update those XML files?

<identifiers xmlns="http://www.opengis.net/crs-nts/1.0" xmlns:gco="http://www.isotc211.org/2005/gco" xmlns:gmd="http://www.isotc211.org/2005/gmd" at="http://www.opengis.net/def/crs/OGC">
<identifier>http://www.opengis.net/def/crs/OGC/0</identifier>
<identifier>http://www.opengis.net/def/crs/OGC/1.3</identifier>
</identifiers>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that they are using http:// instead of https:// ?

@ogcscotts should be able to help, or at least find the person to help.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am checking with the latest discussions and conversations in the OGC Naming Authority... more very soon.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: for OGC Registries, we have revised policy for https (opengeospatial/NamingAuthority#108 (comment))

for schemas.opengis.net, the Architecture Domain Working Group will be meeting in the next weeks and into June to work out a policy and implementation for http and https.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks!

format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
Copy link
Member

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few tweaks on language, but otherwise looks good. Leaving this as a comment so others can merge, will mark 'approve' once these commit.

format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
alasarr and others added 4 commits April 18, 2022 17:58
Co-authored-by: Chris Holmes <chomie@gmail.com>
Co-authored-by: Chris Holmes <chomie@gmail.com>
Co-authored-by: Chris Holmes <chomie@gmail.com>
Co-authored-by: Chris Holmes <chomie@gmail.com>
@alasarr
Copy link
Collaborator Author

alasarr commented Apr 18, 2022

@cholmes thanks a lot for the suggestions! I've just committed them

@cayetanobv
Copy link
Collaborator

Have a few tweaks on language, but otherwise looks good. Leaving this as a comment so others can merge, will mark 'approve' once these commit.

@cholmes I agree with your comments. Thanks!

@cholmes cholmes added this to the 0.2 milestone Apr 18, 2022
@alasarr alasarr merged commit f5c980a into main Apr 18, 2022
@Jesus89 Jesus89 deleted the a/optional-crs branch April 19, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants