Update templated links to support both aware and unaware clients. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into pvretano-issue-275
|
The merge conflicts in PR #290 were so convoluted that is was simpler to just create a new PR based on the latest master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
The gist of the PR is that client who know nothing about templated links should still be able to resolve the link.
This is accomplished by converting the templated member from a boolean to a string that supplies the text of the parameterized URL. If it is present then the href member simply contains an example or representative URL created by picking valid substitution values from the dictionary of substitution variables.
Aware clients can ignore the href value and generate a new resolvable URL using the dictionary of substitution variables.
Unaware clients can ignore all the templated stuff and simply use the value of the href member.