Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report: Fix 'Passed core (Can be certified)' result #248

Closed
dstenger opened this issue Sep 27, 2017 · 4 comments
Closed

HTML report: Fix 'Passed core (Can be certified)' result #248

dstenger opened this issue Sep 27, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@dstenger
Copy link
Contributor

dstenger commented Sep 27, 2017

When reference implementation [1] of ets-wfs20 is tested via Web Browser Interface, the Passed core (Can be certified) result says No although the service passes all basic tests (also add Featureidentifier: PS_PROTECTEDSITE_a367af0b-9457-4445-9cbd-eb48ae7a844a when starting the test).

@keshav-nangare Can you please investigate why the result is wrong?

Further, there should be a space added to text:

  • Current status: Passed core(Can be certified): No
  • Correct status: Passed core (Can be certified): No

[1] http://cite.deegree.org/deegree-webservices-3.4-RC3/services/wfs200?service=WFS&request=GetCapabilities

@keshavnangare
Copy link
Contributor

@dstenger

Maybe we need to add configuration of conformance class in TestNG test then it will show something.

Here is the config link: https://github.com/opengeospatial/cite/wiki/Encoding-Conformance-Classes

In above link there is example to add basic conformance classes.

@dstenger
Copy link
Contributor Author

dstenger commented Oct 2, 2017

Thank you. I added following to the ets-wfs20:

...
      <suite>
        <namespace-uri>http://www.opengis.net/cite/iso19142</namespace-uri>
        <prefix>tns</prefix>
        <local-name>ets-${ets-code}-${version}</local-name>
        <title>WFS 2.0 (ISO 19142:2010) Conformance Test Suite</title>
        <description>Checks WFS 2.0 implementations for conformance to ISO 19142:2010.</description>
        <BasicConformanceClasses>
          <conformanceClass>Preconditions</conformanceClass>
          <conformanceClass>All GML application schemas</conformanceClass>
          <conformanceClass>GML application schemas defining features</conformanceClass>
          <conformanceClass>Simple WFS</conformanceClass>
          <conformanceClass>Basic WFS</conformanceClass>
        </BasicConformanceClasses>
      </suite>
...

However, the test suite now always states following:

Passed core(Can be certified): Yes

This is even the case if not all core tests are passed.

@keshav-nangare Can you please take a look at it?

@keshavnangare
Copy link
Contributor

Now the HTML report will display correct result for core test.

If one of the core test is failed then it will set to 'No' otherwise 'Yes'.

Fixed with this commit: 1b73489

@dstenger
Copy link
Contributor Author

dstenger commented Oct 5, 2017

Fix was successfully tested with [1] and changes from #248 (comment) via TEAM Engine Web Interface.

If Featureidentifier PS_PROTECTEDSITE_a367af0b-9457-4445-9cbd-eb48ae7a844a is passed, report says Passed core (Can be certified): Yes.
If no Featureidentifier is passed, report says Passed core (Can be certified): No.

--> Expected behaviour.

[1] http://cite.deegree.org/deegree-webservices-3.4-RC3/services/wfs200?service=WFS&request=GetCapabilities

@dstenger dstenger added this to the 5.0 milestone Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants