Ensure flux dims order #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved `time` in front of `lat` and `lon`. This reproduces an error reported by Helene.
The hack is assuming that time is the smallest coordinate, but for annual or monthly fluxes, this should be true.
hdelongueville
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inferpymc_postprocessouts, the order of the flux dimensions is inferred by assuming thattimeis the smallest dimension, then the axes of the flux array are re-ordered so that time is the last axis. This is a hack to try to ensure that the flux dims are in the expected order, without using xarraytime,lat,lon`. This test failed initially, reproducing the error @hdelongueville found. After the fix, the test now passes.CHANGELOG.mdfile