118 improve filtering #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatibility ok : can still put as parameter a list of filters (the filters will then be applied to all sites), or a string (also apply to all sites then).
Closed
3 tasks
alexdanjou
requested review from
brendan-m-murphy,
joe-pitt,
ag12733 and
hdelongueville
- `isinstance(x, y)` is preferred to `type(x) is y` - don't need to manage memory or use temp variables to reuse variable name
There was a problem hiding this comment.
When using
filters = {"CMN": None, "JFJ": None, "MHD": ["pblh_inlet_diff", "pblh_min"], "TAC": ["pblh_inlet_diff", "pblh_min"]}
I get the error
File "/user/home/qq24644/openghg_inversions/openghg_inversions/utils.py", line 471, in filtering
datasets[site] = filtering_functions[filt](datasets[site], site, keep_missing=keep_missing)
~~~~~~~~~~~~~~~~~~~^^^^^^
KeyError: None
hdelongueville
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Allow to put filters as dictionnary in .ini (with the sites as keys).
Please check if the PR fulfills these requirements
CHANGELOG.mdfilerequirements.txt