Added min model error options, incl "by site" #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added "robust" option to use median absolute deviation in place of standard deviation.
If calculating a min error for each site, it makes more sense for the mean or median used for `avg` to be calculated for each site.
|
Adding an option for a percentile-based calculation on min_model_error. This changes what is required in the ini - calculate_min_error now takes either "percentile" or "residual". Need to update docs/templates to reflect this |
|
One thing that has just occurred to me - do we need to raise an error in the case when calculate_min_error is neither "percentile", "residual" or None? I guess at the moment if someone gets the spelling wrong it would silently skip the min error calculation |
Raises ValueError if value is not None or one of the two available methods.
Removed "average over" option to take mean (or median) over a subset of the obs, since we weren't using this option. Now there is just an option to calculate the min error separately for each site, or to calculate one value for each site (along with the robust/non-robust option.)
|
@joe-pitt I've updated the docs with the new options and added some code to raise an error if the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added "robust" option to use median absolute deviation in place of standard deviation.
In an ini file use:
to use new options. (Either "by_site" or "robust" can be omitted; or
min_error_optionscan be omitted entirely)CHANGELOG.mdfile