Obs error clean up #144
Merged
Obs error clean up #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The obs uncertainty that will be used for the inversions is stored as "mf_error". The variables "mf_repeatability" and "mf_variability" are retained (and filled with zeros if they were not present initially)
Also added a test. Needed to update merged test data, which necessitated some other updates to the tests.
also fixed some tests, added logger
...to help with debugging issues when uncertainty in likelihood function is zero
This is replaced by the code in `get_data.add_obs_error`
...only used once, could be replaced by `xr.load_dataset`
also updated tests
joe-pitt
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Looks good! I have successfully run inversions on the min_error_by_site_plus_robust branch after this branch was merged in at commit fe0cc36. I haven't run any inversions to test the changes to this branch since that point, but they look fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up code that adds averaging error, using the
mf_variabilityvariable that is created by OpenGHG'sget_obs_surfacefunction.A new variable
mf_erroris created:mf_erroris the sqrt root of the sum of squares of repeatability and variabilitymf_erroris repeatability if it is present, otherwise, it is variability.The output file now includes the variables:
Yerror_repeatabilitycontaining the combinedmf_repeatabilityfor all sitesYerror_variatabilitycontaining the combinedmf_variatabilityfor all sitesThese output variables are needed for the PARIS outputs
addaveragingerrordoesn't actually do anything due to functionality inget_obs_surface#42CHANGELOG.mdfile