Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned numpy to < 2.0 #148

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Pinned numpy to < 2.0 #148

merged 1 commit into from
Jul 1, 2024

Conversation

brendan-m-murphy
Copy link
Contributor

@brendan-m-murphy brendan-m-murphy commented Jun 28, 2024

  • Summary of changes

Pytensor hasn't upgraded to numpy 2.0 yet so we need to wait for that. OpenGHG is also pinned at numpy < 2.0

  • Please check if the PR fulfills these requirements
  • Added any new requirements to requirements.txt

Pytensor hasn't upgraded to numpy 2.0 yet so we need to wait for that.
OpenGHG is also pinned at numpy < 2.0
@brendan-m-murphy brendan-m-murphy marked this pull request as ready for review June 28, 2024 15:30
@rt17603
Copy link

rt17603 commented Jul 1, 2024

Would you be able to update the PR description to remove the tick boxes if they're not needed (or tick if done)? Just makes it easier to use the checklist for this.

Copy link
Contributor

@joe-pitt joe-pitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice straightforward one!

@brendan-m-murphy brendan-m-murphy merged commit 4df5c9b into devel Jul 1, 2024
3 checks passed
@brendan-m-murphy brendan-m-murphy deleted the pin-numpy-to-before-2.0 branch July 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants