Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use openghg combine datasets #160

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Use openghg combine datasets #160

merged 3 commits into from
Jul 5, 2024

Conversation

brendan-m-murphy
Copy link
Contributor

@brendan-m-murphy brendan-m-murphy commented Jul 4, 2024 •
edited
Loading

  • Summary of changes

utils.combine_datasets outsourced to openghg (currently a thin wrapper function is used to load the second dataset until the next OpenGHG release, since this .load() call has important performance impacts, and this change is only on the devel branch of OpenGHG)

  • Please check if the PR fulfills these requirements
  • Added an entry to the CHANGELOG.md file

@brendan-m-murphy
Moved to OpenGHG's version of combine_datasets
73f1c73 
We slightly redefine the openghg version. Pending some
updates to OpenGHG, this can be removed.
@brendan-m-murphy
Updated combined_datasets docstring
d81303e
@brendan-m-murphy
Updated changelog
c55b030
@brendan-m-murphy brendan-m-murphy marked this pull request as ready for review July 4, 2024 15:22
@brendan-m-murphy brendan-m-murphy merged commit ef0e935 into devel Jul 5, 2024
3 checks passed
@brendan-m-murphy brendan-m-murphy deleted the use-openghg-combine-datasets branch July 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdanjou alexdanjou Awaiting requested review from alexdanjou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brendan-m-murphy